what about *.cjs?
and .prettierrc.js should be cjs, too

For reference, I suppose, this is how I made my "One lint config" for all apps, addons, v2 addons: https://github.com/NullVoxPopuli/eslint-configs/blob/main/configs/ember.js#L12

what about *.cjs? and .prettierrc.js should be cjs, too

only the files that I've touched here are delivered from this repo (eg https://github.com/embroider-build/addon-blueprint/blob/main/files/__addonLocation__/.eslintrc.cjs), the rest seem to be from the base addon
as far as I've generated the addon with this command it creates a .prettierrc.js and not a .cjs file hence I've left that as is
the changes here are correct as for the output of this blueprint (to the best of my ability to verify)

not sure what if anything you expect to be different here

It's just that if we throw type=module in the package.json, the prettier file will be required to be cjs

It's just that if we throw type=module in the package.json, the prettier file will be required to be cjs

these are regex's so how about I make all options valid?

How do you mean? All the 'node files' should be .cjs, and then this eslint entry can be *.cjs instead of the 4 or 5 lines it is now. But, i think bucause all our browser code is in src, we could probably safely assume all *.{cjs,js} are node. The toplevel cjs in def node, and the top level js would be esm. One eslint entry to rule them all! (Of the package root lol)

(tho, because parserType is 'script', only cjs is supported atm -- kinda obnoxious that esm and cjs need different parsers.)

@void-mAlex @NullVoxPopuli When setting decoratorsBeforeExport to true, does one need to configure their v2 addon somehow more?

Some tests for the docs and test apps for ember-container-query failed locally and in CI: https://github.com/ijlee2/ember-container-query/actions/runs/5124925949

# One type of error
Error: Assertion Failed: The options object passed to tracked() may only contain a 'value' or 'initializer' property, not both. Received: [kind,key,placement,descriptor,ini

# Another type
ReferenceError: Cannot access 'ContainerQueryComponent' before initialization

# And another
TypeError: An element descriptor's .kind property must be either "method" or "field", but a decorator created an element descriptor with .kind "undefined"

I couldn't find examples of other addons that currently use decoratorsBeforeExport: true.

https://emberobserver.com/code-search?codeQuery=decoratorsBeforeExport&fileFilter=babel

ah, this was probably a mistake, we should bring to legacy - can you PR an update? I have my release machine setup atm, so I can push it out pretty quick

Yes, I will create a PR, thanks for the quick feedback.

#127